From: Andrew Bartlett <abartlet@samba.org>
Date: Sat, 1 Sep 2012 01:29:46 +0000 (+1000)
Subject: s4-dsdb: Remove unused tmp_ctx leaked onto long-term ldb_context
X-Git-Tag: samba-4.0.0rc1~294
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=01ade93c7c0c2f2e992f5295976bbfc20429023a;p=thirdparty%2Fsamba.git

s4-dsdb: Remove unused tmp_ctx leaked onto long-term ldb_context

This was found based on a log provided by Ricky Nance
<ricky.nance@weaubleau.k12.mo.us>.  Thanks Ricky!

Andrew Bartlett
---

diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
index 5d73df2ec39..a2ff688cfa7 100644
--- a/source4/dsdb/common/util.c
+++ b/source4/dsdb/common/util.c
@@ -1618,12 +1618,10 @@ int samdb_reference_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, struct ldb_
 int samdb_dn_is_our_ntdsa(struct ldb_context *ldb, struct ldb_dn *dn, bool *is_ntdsa)
 {
 	NTSTATUS status;
-	TALLOC_CTX *tmp_ctx = talloc_new(ldb);
 	struct GUID dn_guid;
 	const struct GUID *our_ntds_guid;
 	status = dsdb_get_extended_dn_guid(dn, &dn_guid, "GUID");
 	if (!NT_STATUS_IS_OK(status)) {
-		talloc_free(tmp_ctx);
 		return LDB_ERR_OPERATIONS_ERROR;
 	}