From: Lucas De Marchi <lucas.de.marchi@gmail.com>
Date: Thu, 7 Nov 2024 17:13:11 +0000 (-0600)
Subject: build: Drop define not picked by meson
X-Git-Tag: v34~125
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=01c8b02c5a00d554acd4b8eb14128ba92370ce88;p=thirdparty%2Fkmod.git

build: Drop define not picked by meson

For almost 13 years, since commit 769becb5dbfb ("tools: kmod: Add
handling of compat modinfo") we have a non-spoken joke in the build
system showing "-DANOTHER_BRICK_IN_THE -Wall" in honour of the famous
Pink Floyd song.

With configure flags now being sorted, I'm looking at the logs and
seeing:	"-DANOTHER_BRICK_IN_THE -fdata-sections". That makes no sense.
Also the new meson build system did not join the joke. Not fun. Let's
drop it and let this commit serve as recognition of what it was.

Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/226
---

diff --git a/configure.ac b/configure.ac
index b37946c0..233fd274 100644
--- a/configure.ac
+++ b/configure.ac
@@ -257,7 +257,6 @@ PKG_NOARCH_INSTALLDIR
 
 CC_CHECK_FLAGS_APPEND(with_cflags, [CFLAGS], [\
 		       -pipe \
-		       -DANOTHER_BRICK_IN_THE \
 		       -fdata-sections \
 		       -fdiagnostics-show-option \
 		       -ffunction-sections \