From: Jeremy Allison <jra@samba.org>
Date: Fri, 27 Apr 2012 23:02:15 +0000 (-0700)
Subject: Fix remove_duplicate_addrs2 to do exactly what it says. Previously it could leave... 
X-Git-Tag: samba-4.0.0alpha20~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=01e884675e3d1cffb0149108225fbd21c3a73f4e;p=thirdparty%2Fsamba.git

Fix remove_duplicate_addrs2 to do exactly what it says. Previously it could leave zero addresses in the list.
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index a604f05d81a..0f2c66f32a9 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -1109,7 +1109,7 @@ static int remove_duplicate_addrs2(struct ip_service *iplist, int count )
 	DEBUG(10,("remove_duplicate_addrs2: "
 			"looking for duplicate address/port pairs\n"));
 
-	/* one loop to remove duplicates */
+	/* One loop to set duplicates to a zero addr. */
 	for ( i=0; i<count; i++ ) {
 		if ( is_zero_addr(&iplist[i].ss)) {
 			continue;
@@ -1124,18 +1124,17 @@ static int remove_duplicate_addrs2(struct ip_service *iplist, int count )
 		}
 	}
 
-	/* one loop to clean up any holes we left */
-	/* first ip should never be a zero_ip() */
-	for (i = 0; i<count; ) {
-		if (is_zero_addr(&iplist[i].ss) ) {
-			if (i != count-1) {
-				memmove(&iplist[i], &iplist[i+1],
-					(count - i - 1)*sizeof(iplist[i]));
+	/* Now remove any addresses set to zero above. */
+	for (i = 0; i < count; i++) {
+		while (i < count &&
+				is_zero_addr(&iplist[i].ss)) {
+			if (count-i-1>0) {
+				memmove(&iplist[i],
+					&iplist[i+1],
+					(count-i-1)*sizeof(struct ip_service));
 			}
 			count--;
-			continue;
 		}
-		i++;
 	}
 
 	return count;