From: Evan You <yyx990803@gmail.com>
Date: Mon, 25 Nov 2019 15:04:00 +0000 (-0500)
Subject: feat(transition): warn non-animatable component root node
X-Git-Tag: v3.0.0-alpha.0~153
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=01eb3c12e9711bd1efb5f1e8ee48a34dd315b380;p=thirdparty%2Fvuejs%2Fcore.git

feat(transition): warn non-animatable component root node
---

diff --git a/packages/runtime-core/src/componentRenderUtils.ts b/packages/runtime-core/src/componentRenderUtils.ts
index d42982d580..7663677c67 100644
--- a/packages/runtime-core/src/componentRenderUtils.ts
+++ b/packages/runtime-core/src/componentRenderUtils.ts
@@ -88,7 +88,16 @@ export function renderComponentRoot(
 
     // inherit transition data
     if (vnode.transition != null) {
-      // TODO warn if component has transition data but root is a fragment
+      if (
+        __DEV__ &&
+        !(result.shapeFlag & ShapeFlags.COMPONENT) &&
+        !(result.shapeFlag & ShapeFlags.ELEMENT)
+      ) {
+        warn(
+          `Component inside <Transition> renders non-element root node ` +
+            `that cannot be animated.`
+        )
+      }
       result.transition = vnode.transition
     }
   } catch (err) {