From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 10 Jul 2019 04:24:46 +0000 (+1200)
Subject: dcerpc: use anon creds for unknown transport
X-Git-Tag: tdb-1.4.2~569
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0348dd4b31062b2cf12d19ec5515a309d1d9b470;p=thirdparty%2Fsamba.git

dcerpc: use anon creds for unknown transport

Otherwise we get a segfault when the NULL creds are dereferenced in cli_credentials_is_anonymous()

 $  python3 -c"from samba.dcerpc.dnsserver import dnsserver; d = dnsserver('addc')"

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jul 22 23:37:57 UTC 2019 on sn-devel-184
---

diff --git a/source4/librpc/rpc/dcerpc_connect.c b/source4/librpc/rpc/dcerpc_connect.c
index c23e85e7cb1..f7656e5d7cd 100644
--- a/source4/librpc/rpc/dcerpc_connect.c
+++ b/source4/librpc/rpc/dcerpc_connect.c
@@ -1069,6 +1069,11 @@ _PUBLIC_ struct composite_context* dcerpc_pipe_connect_b_send(TALLOC_CTX *parent
 		epm_creds = credentials;
 		break;
 	default:
+		DBG_INFO("Unknown transport; continuing with anon, no endpoint.\n");
+		epm_creds = cli_credentials_init_anon(s);
+		if (composite_nomem(epm_creds, c)){
+			return c;
+		}
 		break;
 	}