From: Roger Serwy <roger.serwy@gmail.com>
Date: Wed, 12 Jun 2013 03:13:17 +0000 (-0500)
Subject: #5492: Avoid traceback when exiting IDLE caused by a race condition.
X-Git-Tag: v3.4.0a1~529^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=036e84924a0e0bdcc3c17033ea0263a3462825e1;p=thirdparty%2FPython%2Fcpython.git

#5492: Avoid traceback when exiting IDLE caused by a race condition.
---

diff --git a/Lib/idlelib/PyShell.py b/Lib/idlelib/PyShell.py
index e9cef9b884ad..7f2b775f4561 100644
--- a/Lib/idlelib/PyShell.py
+++ b/Lib/idlelib/PyShell.py
@@ -367,6 +367,7 @@ class ModifiedInterpreter(InteractiveInterpreter):
         self.port = PORT
         self.original_compiler_flags = self.compile.compiler.flags
 
+    _afterid = None
     rpcclt = None
     rpcsubproc = None
 
@@ -486,6 +487,8 @@ class ModifiedInterpreter(InteractiveInterpreter):
         threading.Thread(target=self.__request_interrupt).start()
 
     def kill_subprocess(self):
+        if self._afterid is not None:
+            self.tkconsole.text.after_cancel(self._afterid)
         try:
             self.rpcclt.listening_sock.close()
         except AttributeError:  # no socket
@@ -561,8 +564,8 @@ class ModifiedInterpreter(InteractiveInterpreter):
                 pass
         # Reschedule myself
         if not self.tkconsole.closing:
-            self.tkconsole.text.after(self.tkconsole.pollinterval,
-                                      self.poll_subprocess)
+            self._afterid = self.tkconsole.text.after(
+                self.tkconsole.pollinterval, self.poll_subprocess)
 
     debugger = None
 
@@ -973,10 +976,6 @@ class PyShell(OutputWindow):
         self.stop_readline()
         self.canceled = True
         self.closing = True
-        # Wait for poll_subprocess() rescheduling to stop
-        self.text.after(2 * self.pollinterval, self.close2)
-
-    def close2(self):
         return EditorWindow.close(self)
 
     def _close(self):
diff --git a/Misc/NEWS b/Misc/NEWS
index 50937a99ae67..cd76c4c6238f 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -81,6 +81,8 @@ Library
 IDLE
 ----
 
+- Issue #5492: Avoid traceback when exiting IDLE caused by a race condition.
+
 - Issue #17511: Keep IDLE find dialog open after clicking "Find Next".
   Original patch by Sarah K.