From: Artem Lytkin Date: Sat, 7 Feb 2026 22:05:44 +0000 (+0000) Subject: staging: media: av7110: replace BUG() with error return in gpioirq X-Git-Tag: v7.1-rc1~169^2~150 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=03fd5070c57acc99a21123a960f4820a6693e910;p=thirdparty%2Fkernel%2Flinux.git staging: media: av7110: replace BUG() with error return in gpioirq Replace BUG() with a return statement in the gpioirq tasklet handler. If saa7146_wait_for_debi_done() times out, crashing the kernel is disproportionate. The pr_err() already logs the failure, and returning early avoids accessing hardware in a potentially broken state. Signed-off-by: Artem Lytkin Signed-off-by: Hans Verkuil --- diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c index 607992100baf2..014d0c6f0a8ba 100644 --- a/drivers/staging/media/av7110/av7110.c +++ b/drivers/staging/media/av7110/av7110.c @@ -460,7 +460,7 @@ static void gpioirq(struct tasklet_struct *t) if (saa7146_wait_for_debi_done(av7110->dev, 0)) { pr_err("%s(): saa7146_wait_for_debi_done timed out\n", __func__); - BUG(); /* maybe we should try resetting the debi? */ + return; } spin_lock(&av7110->debilock);