From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Wed, 28 Dec 2022 01:16:53 +0000 (-0800)
Subject: gh-100553: Improve accuracy of sqlite3.Row iter test (GH-100555)
X-Git-Tag: v3.10.10~87
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=04285502ba7d90e41138b0282434372be18ac042;p=thirdparty%2FPython%2Fcpython.git

gh-100553: Improve accuracy of sqlite3.Row iter test (GH-100555)

(cherry picked from commit 3dc48dabd48864039951715816e07986a4828d80)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
---

diff --git a/Lib/sqlite3/test/factory.py b/Lib/sqlite3/test/factory.py
index 876428497542..40a290f0c981 100644
--- a/Lib/sqlite3/test/factory.py
+++ b/Lib/sqlite3/test/factory.py
@@ -155,8 +155,14 @@ class RowFactoryTests(unittest.TestCase):
         """Checks if the row object is iterable"""
         self.con.row_factory = sqlite.Row
         row = self.con.execute("select 1 as a, 2 as b").fetchone()
-        for col in row:
-            pass
+
+        # Is iterable in correct order and produces valid results:
+        items = [col for col in row]
+        self.assertEqual(items, [1, 2])
+
+        # Is iterable the second time:
+        items = [col for col in row]
+        self.assertEqual(items, [1, 2])
 
     def test_sqlite_row_as_tuple(self):
         """Checks if the row object can be converted to a tuple"""