From: Victor Stinner <vstinner@python.org>
Date: Mon, 18 Nov 2019 16:39:48 +0000 (+0100)
Subject: bpo-38631: Avoid Py_FatalError() in float.__getformat__() (GH-17232)
X-Git-Tag: v3.9.0a1~14
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=04394df74b3d0783893da7dafa7803a003516402;p=thirdparty%2FPython%2Fcpython.git

bpo-38631: Avoid Py_FatalError() in float.__getformat__() (GH-17232)

Replace Py_FatalError() with a regular RuntimeError exception in
float.__getformat__().
---

diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-11-18-17-10-20.bpo-38631.tRHaAk.rst b/Misc/NEWS.d/next/Core and Builtins/2019-11-18-17-10-20.bpo-38631.tRHaAk.rst
new file mode 100644
index 000000000000..d05ad05941ec
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2019-11-18-17-10-20.bpo-38631.tRHaAk.rst	
@@ -0,0 +1,2 @@
+Replace ``Py_FatalError()`` call with a regular :exc:`RuntimeError`
+exception in :meth:`float.__getformat__`.
diff --git a/Objects/floatobject.c b/Objects/floatobject.c
index 8c08866d7372..3f9bbde2abe0 100644
--- a/Objects/floatobject.c
+++ b/Objects/floatobject.c
@@ -1726,7 +1726,8 @@ float___getformat___impl(PyTypeObject *type, const char *typestr)
     case ieee_big_endian_format:
         return PyUnicode_FromString("IEEE, big-endian");
     default:
-        Py_FatalError("insane float_format or double_format");
+        PyErr_SetString(PyExc_RuntimeError,
+                        "insane float_format or double_format");
         return NULL;
     }
 }