From: Matthieu Patou <mat@matws.net>
Date: Thu, 13 Dec 2012 10:18:34 +0000 (-0800)
Subject: ldb: use strncmp instead of strcmp when comparing the val part
X-Git-Tag: tevent-0.9.18~269
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=057896a090870ecec56ad0d2f960e55cef561e9e;p=thirdparty%2Fsamba.git

ldb: use strncmp instead of strcmp when comparing the val part

val part of a DN's component is DATA_BLOB and nothing insure that it
will be finished by a '\0'

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c
index b910489a8e8..14596f6c371 100644
--- a/lib/ldb/common/ldb_dn.c
+++ b/lib/ldb/common/ldb_dn.c
@@ -1097,7 +1097,7 @@ int ldb_dn_compare_base(struct ldb_dn *base, struct ldb_dn *dn)
 		if (b_vlen != dn_vlen) {
 			return b_vlen - dn_vlen;
 		}
-		ret = strcmp(b_vdata, dn_vdata);
+		ret = strncmp(b_vdata, dn_vdata, b_vlen);
 		if (ret != 0) return ret;
 
 		n_base--;
@@ -1176,7 +1176,7 @@ int ldb_dn_compare(struct ldb_dn *dn0, struct ldb_dn *dn1)
 		if (dn0_vlen != dn1_vlen) {
 			return dn0_vlen - dn1_vlen;
 		}
-		ret = strcmp(dn0_vdata, dn1_vdata);
+		ret = strncmp(dn0_vdata, dn1_vdata, dn0_vlen);
 		if (ret != 0) {
 			return ret;
 		}