From: Stefan Eissing <stefan@eissing.org>
Date: Fri, 10 Oct 2025 08:40:55 +0000 (+0200)
Subject: c-ares: when resolving failed, persist error
X-Git-Tag: rc-8_17_0-1~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=05fbe85e628ca697e7f3c59bd677024e3cec125c;p=thirdparty%2Fcurl.git

c-ares: when resolving failed, persist error

Repeated calls to `Curl_async_is_resolved()` after a failure
returned OK and not the error that was the result of the resolve
fail.

Reported-by: Joshua Rogers
Closes #18999
---

diff --git a/lib/asyn-ares.c b/lib/asyn-ares.c
index dcbed0129c..d39db23a7b 100644
--- a/lib/asyn-ares.c
+++ b/lib/asyn-ares.c
@@ -302,11 +302,13 @@ CURLcode Curl_async_is_resolved(struct Curl_easy *data,
 
   if(data->state.async.done) {
     *dns = data->state.async.dns;
-    return CURLE_OK;
+    return ares->result;
   }
 
-  if(Curl_ares_perform(ares->channel, 0) < 0)
-    return CURLE_UNRECOVERABLE_POLL;
+  if(Curl_ares_perform(ares->channel, 0) < 0) {
+    result = CURLE_UNRECOVERABLE_POLL;
+    goto out;
+  }
 
 #ifndef HAVE_CARES_GETADDRINFO
   /* Now that we have checked for any last minute results above, see if there
@@ -371,6 +373,9 @@ CURLcode Curl_async_is_resolved(struct Curl_easy *data,
                  result, *dns ? "" : "not ");
     async_ares_cleanup(data);
   }
+
+out:
+  ares->result = result;
   return result;
 }