From: Volker Lendecke <vl@samba.org>
Date: Sat, 1 Apr 2023 10:47:51 +0000 (+0200)
Subject: libsmb: Slightly simplify smbc_init()
X-Git-Tag: talloc-2.4.1~897
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=061aaf8622a284ff1db0060b39dbfbc59a3f199e;p=thirdparty%2Fsamba.git

libsmb: Slightly simplify smbc_init()

Reduce indentation with an early return, review with git show -w

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/libsmb/libsmb_compat.c b/source3/libsmb/libsmb_compat.c
index c916122d0b8..465bb3c70ee 100644
--- a/source3/libsmb/libsmb_compat.c
+++ b/source3/libsmb/libsmb_compat.c
@@ -117,23 +117,24 @@ int
 smbc_init(smbc_get_auth_data_fn fn,
           int debug)
 {
-	if (!smbc_compat_initialized) {
-		statcont = smbc_new_context();
-		if (!statcont)
-			return -1;
-
-                smbc_setDebug(statcont, debug);
-                smbc_setFunctionAuthData(statcont, fn);
+	if (smbc_compat_initialized) {
+		return 0;
+	}
 
-		if (!smbc_init_context(statcont)) {
-			smbc_free_context(statcont, False);
-			return -1;
-		}
+	statcont = smbc_new_context();
+	if (!statcont)
+		return -1;
 
-		smbc_compat_initialized = 1;
+	smbc_setDebug(statcont, debug);
+	smbc_setFunctionAuthData(statcont, fn);
 
-		return 0;
+	if (!smbc_init_context(statcont)) {
+		smbc_free_context(statcont, False);
+		return -1;
 	}
+
+	smbc_compat_initialized = 1;
+
 	return 0;
 }