From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Tue, 5 May 2026 04:59:49 +0000 (-0700)
Subject: Input: rmi4 - propagate proper error code in F12 sensor tuning
X-Git-Tag: v7.2-rc1~44^2^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0655e58946e480cb99fb276e87280d0715b32ada;p=thirdparty%2Flinux.git

Input: rmi4 - propagate proper error code in F12 sensor tuning

Propagate the actual error code returned by rmi_read() in
rmi_f12_read_sensor_tuning() instead of hardcoding -ENODEV.
Also, since rmi_read() returns 0 on success, use 'if (ret)'
instead of 'if (ret < 0)'.

Assisted-by: Gemini:gemini-3.1-pro
Link: https://patch.msgid.link/20260505045952.1570713-19-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index ea72d5ce80508..bf8c4a0e10ded 100644
--- a/drivers/input/rmi4/rmi_f12.c
+++ b/drivers/input/rmi4/rmi_f12.c
@@ -166,9 +166,9 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
 						RMI_F12_QUERY_RESOLUTION);
 		query_dpm_addr = fn->fd.query_base_addr	+ offset;
 		ret = rmi_read(fn->rmi_dev, query_dpm_addr, buf);
-		if (ret < 0) {
+		if (ret) {
 			dev_err(&fn->dev, "Failed to read DPM value: %d\n", ret);
-			return -ENODEV;
+			return ret;
 		}
 		dpm_resolution = buf[0];