From: Thomas Markwalder Date: Wed, 4 Jan 2017 18:21:06 +0000 (-0500) Subject: [5032] Fixed some wording and broken unit test X-Git-Tag: trac5044_base~1^2~4 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=069a041e488ec6c3bb86946c3f5a576a46e80163;p=thirdparty%2Fkea.git [5032] Fixed some wording and broken unit test Fixed couple word nits src/bin/dhcp4/tests/parser_unittest.cc void testFile(const std::string& fname) - removed call to unlink as it a: doesn't compile on my Mac and b: is not necessary --- diff --git a/doc/examples/kea4/advanced.json b/doc/examples/kea4/advanced.json index d7bb7a432d..1b0e87778a 100644 --- a/doc/examples/kea4/advanced.json +++ b/doc/examples/kea4/advanced.json @@ -93,7 +93,7 @@ "pools": [ { "pool": "192.0.4.1 - 192.0.4.254" } ], "subnet": "192.0.4.0/24", - // Sometimes the relay may use an IPv4 address that's not matching + // Sometimes the relay may use an IPv4 address that does not match // the subnet. This is discouraged, but there are valid cases when it // makes sense. One case is when there is a shared subnet. "relay": { diff --git a/src/bin/dhcp4/tests/parser_unittest.cc b/src/bin/dhcp4/tests/parser_unittest.cc index 7edf6d5a15..20f6c849d8 100644 --- a/src/bin/dhcp4/tests/parser_unittest.cc +++ b/src/bin/dhcp4/tests/parser_unittest.cc @@ -233,8 +233,6 @@ void testFile(const std::string& fname) { ASSERT_TRUE(test_json); compareJSON(reference_json, test_json); - - unlink(decommented); } // This test loads all available existing files. Each config is loaded @@ -526,7 +524,7 @@ TEST(ParserTest, unicodeEscapes) { } } -// This test checks that all representations of a slash is recognized properly. +// This test checks that all representations of a slash are recognized properly. TEST(ParserTest, unicodeSlash) { // check the 4 possible encodings of solidus '/' ConstElementPtr result;