From: Noel Power Date: Thu, 11 Jul 2019 11:33:18 +0000 (+0000) Subject: s4/libcli/raw: clang: Fix 'initialization value is never read' X-Git-Tag: talloc-2.3.0~80 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=06c3a493d99846af62c185a9db1a6823726ac1fc;p=thirdparty%2Fsamba.git s4/libcli/raw: clang: Fix 'initialization value is never read' Fixes: source4/libcli/raw/rawnegotiate.c:157:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_INTERNAL_ERROR; ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- diff --git a/source4/libcli/raw/rawnegotiate.c b/source4/libcli/raw/rawnegotiate.c index cec081c364a..51c6f0f9ecb 100644 --- a/source4/libcli/raw/rawnegotiate.c +++ b/source4/libcli/raw/rawnegotiate.c @@ -154,7 +154,7 @@ NTSTATUS smb_raw_negotiate_recv(struct tevent_req *req) NTSTATUS smb_raw_negotiate(struct smbcli_transport *transport, bool unicode, int minprotocol, int maxprotocol) { - NTSTATUS status = NT_STATUS_INTERNAL_ERROR; + NTSTATUS status; struct tevent_req *subreq = NULL; bool ok; @@ -164,7 +164,8 @@ NTSTATUS smb_raw_negotiate(struct smbcli_transport *transport, bool unicode, minprotocol, maxprotocol); if (subreq == NULL) { - return NT_STATUS_NO_MEMORY; + status = NT_STATUS_NO_MEMORY; + goto failed; } ok = tevent_req_poll(subreq, transport->ev);