From: Björn Jacke <bj@sernet.de>
Date: Fri, 17 Jun 2022 05:24:28 +0000 (+0200)
Subject: nfs4_acls.c: prefer capabilities over become_root
X-Git-Tag: talloc-2.4.2~649
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=06e5c1e32ea7907523cc19f021225e7541e2075f;p=thirdparty%2Fsamba.git

nfs4_acls.c: prefer capabilities over become_root

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
---

diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c
index 44c4718d3e4..cc9233da87d 100644
--- a/source3/modules/nfs4_acls.c
+++ b/source3/modules/nfs4_acls.c
@@ -1201,12 +1201,12 @@ NTSTATUS smb_set_nt_acl_nfs4(vfs_handle_struct *handle, files_struct *fsp,
 	smbacl4_dump_nfs4acl(10, theacl);
 
 	if (set_acl_as_root) {
-		become_root();
+		set_effective_capability(DAC_OVERRIDE_CAPABILITY);
 	}
 	result = set_nfs4_native(handle, fsp, theacl);
 	saved_errno = errno;
 	if (set_acl_as_root) {
-		unbecome_root();
+		drop_effective_capability(DAC_OVERRIDE_CAPABILITY);
 	}
 
 	TALLOC_FREE(frame);