From: Christoph Hellwig Date: Mon, 29 Jul 2024 23:22:54 +0000 (-0700) Subject: xfs: remove the unusued tmp_logflags variable in xfs_bmapi_allocate X-Git-Tag: v6.10.0~24^2~20 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=06efd1488b6e24615dcc5c4d27ede0992e788983;p=thirdparty%2Fxfsprogs-dev.git xfs: remove the unusued tmp_logflags variable in xfs_bmapi_allocate Source kernel commit: b11ed354c9f725ece2b9440dd6343b42cd5d031c tmp_logflags is initialized to 0 and then ORed into bma->logflags, which isn't actually doing anything. Signed-off-by: Christoph Hellwig Reviewed-by: "Darrick J. Wong" Signed-off-by: Chandan Babu R --- diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c index 84760c88..f236e40d 100644 --- a/libxfs/xfs_bmap.c +++ b/libxfs/xfs_bmap.c @@ -4176,7 +4176,6 @@ xfs_bmapi_allocate( struct xfs_mount *mp = bma->ip->i_mount; int whichfork = xfs_bmapi_whichfork(bma->flags); struct xfs_ifork *ifp = xfs_ifork_ptr(bma->ip, whichfork); - int tmp_logflags = 0; int error; ASSERT(bma->length > 0); @@ -4247,8 +4246,6 @@ xfs_bmapi_allocate( error = xfs_bmap_add_extent_hole_real(bma->tp, bma->ip, whichfork, &bma->icur, &bma->cur, &bma->got, &bma->logflags, bma->flags); - - bma->logflags |= tmp_logflags; if (error) return error;