From: Sami Kerola <kerolasa@iki.fi>
Date: Tue, 7 Feb 2012 21:14:34 +0000 (+0100)
Subject: libblkid: clarify operation order [cppcheck]
X-Git-Tag: v2.21~40
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=07023b0736cebde0a469caea5bc9b9c99d64b01e;p=thirdparty%2Futil-linux.git

libblkid: clarify operation order [cppcheck]

[libblkid/src/cache.c:265]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/libblkid/src/cache.c b/libblkid/src/cache.c
index 2eab2d3292..a60495aa50 100644
--- a/libblkid/src/cache.c
+++ b/libblkid/src/cache.c
@@ -262,7 +262,7 @@ int main(int argc, char** argv)
 			argv[0], ret);
 		exit(1);
 	}
-	if ((ret = blkid_probe_all(cache) < 0))
+	if ((ret = blkid_probe_all(cache)) < 0)
 		fprintf(stderr, "error probing devices\n");
 
 	blkid_put_cache(cache);