From: Douglas Bagnall Date: Tue, 16 Apr 2024 23:42:30 +0000 (+1200) Subject: ldb:pytests: test for Turkic i-dots in ldb_comparison_fold X-Git-Tag: tdb-1.4.11~1018 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=078ecf486a62dc3aaa2842ada96456ac9870dad7;p=thirdparty%2Fsamba.git ldb:pytests: test for Turkic i-dots in ldb_comparison_fold In tr_TR and some other locales where the letter 'i' uppercases to 'İ', which is not ideal for LDB as we need certain strings like 'guid' to casefold in the ASCII way. In fixing https://bugzilla.samba.org/show_bug.cgi?id=15248) we solved this problem in many cases, but for unindexed searches where the 'i' is not the last character in the string. This test shows that. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15637 Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/lib/ldb/tests/python/api.py b/lib/ldb/tests/python/api.py index 88dfa8c3b71..0fc31e3fe09 100755 --- a/lib/ldb/tests/python/api.py +++ b/lib/ldb/tests/python/api.py @@ -1341,6 +1341,22 @@ class SearchTests(LdbBaseTest): expression="(ou=unique)") self.assertEqual(len(res11), 1) + def test_subtree_uni123_elsewhere(self): + """Testing a search, where the search term contains a (normal ASCII) + dotted-i, that will be upper-cased to 'Ä°', U+0130, LATIN + CAPITAL LETTER I WITH DOT ABOVE in certain locales including + tr_TR in which this test is sometimes run. + + The search term should fail because the ou does not exist, but + we used to get it wrong in unindexed searches which stopped + comparing at the i, ignoring the rest of the string, which is + not the same as the existing ou ('123' != 'que'). + """ + res11 = self.l.search(base="DC=EXAMPLE,DC=NET", + scope=ldb.SCOPE_SUBTREE, + expression="(ou=uni123)") + self.assertEqual(len(res11), 0) + def test_subtree_unique_elsewhere3(self): """Testing a search""" diff --git a/selftest/knownfail.d/ldb.python.api.tr b/selftest/knownfail.d/ldb.python.api.tr new file mode 100644 index 00000000000..f327762e70b --- /dev/null +++ b/selftest/knownfail.d/ldb.python.api.tr @@ -0,0 +1,2 @@ +^ldb.python.api.tr.api.SearchTests.test_subtree_uniquer_elsewhere.none +^ldb.python.api.tr.api.SearchTestsLmdb.test_subtree_uniquer_elsewhere.none