From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 15 May 2019 18:58:46 +0000 (-0400)
Subject: Coverage: do not include test-rebind in coverage builds.
X-Git-Tag: tor-0.4.1.2-alpha~29^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=07ccffa989a8c6ac6ac216b6e729daed14372620;p=thirdparty%2Ftor.git

Coverage: do not include test-rebind in coverage builds.

Because it invokes the Tor mainloop, it does unpredictable things to
test coverage of a lot of code that it doesn't actually test at
all.  (It is more an integration test than anything else.)
---

diff --git a/src/test/include.am b/src/test/include.am
index 824089bc47..85f9c9f880 100644
--- a/src/test/include.am
+++ b/src/test/include.am
@@ -32,8 +32,15 @@ endif
 
 if USEPYTHON
 TESTSCRIPTS += src/test/test_ntor.sh src/test/test_hs_ntor.sh src/test/test_bt.sh
+
+if COVERAGE_ENABLED
+# ...
+else
+# Only do this when coverage is not on, since it invokes lots of code
+# in a kind of unpredictable way.
 TESTSCRIPTS += src/test/test_rebind.sh
 endif
+endif
 
 TESTS += src/test/test src/test/test-slow src/test/test-memwipe \
 	src/test/test_workqueue \