From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 16 Oct 2023 06:10:56 +0000 (+1300)
Subject: s4:torture: Fix leaks
X-Git-Tag: talloc-2.4.2~1231
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=07ec3457dc202fe7bd4e678783e621522d7dbe18;p=thirdparty%2Fsamba.git

s4:torture: Fix leaks

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/torture/rpc/backupkey.c b/source4/torture/rpc/backupkey.c
index 8b7c6c30d10..49c22f7d5b6 100644
--- a/source4/torture/rpc/backupkey.c
+++ b/source4/torture/rpc/backupkey.c
@@ -276,11 +276,13 @@ static DATA_BLOB *create_access_check(struct torture_context *tctx,
 
 	sid = get_user_sid(tctx, tmp_ctx, user);
 	if (sid == NULL) {
+		talloc_free(tmp_ctx);
 		return NULL;
 	}
 
 	blob = talloc_zero(mem_ctx, DATA_BLOB);
 	if (blob == NULL) {
+		talloc_free(tmp_ctx);
 		return NULL;
 	}
 
@@ -298,6 +300,8 @@ static DATA_BLOB *create_access_check(struct torture_context *tctx,
 		ndr_err = ndr_push_struct_blob(blob, blob, &access_struct,
 				(ndr_push_flags_fn_t)ndr_push_bkrp_access_check_v2);
 		if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+			talloc_free(blob);
+			talloc_free(tmp_ctx);
 			return NULL;
 		}
 
@@ -334,6 +338,8 @@ static DATA_BLOB *create_access_check(struct torture_context *tctx,
 		ndr_err = ndr_push_struct_blob(blob, blob, &access_struct,
 				(ndr_push_flags_fn_t)ndr_push_bkrp_access_check_v3);
 		if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+			talloc_free(blob);
+			talloc_free(tmp_ctx);
 			return NULL;
 		}