From: David Herrmann <dh.herrmann@gmail.com>
Date: Fri, 31 Jul 2015 09:51:33 +0000 (+0200)
Subject: basic: fix error/memleak in socket-util
X-Git-Tag: v224~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0810bc568ace619b16e440805e93256730d45541;p=thirdparty%2Fsystemd.git

basic: fix error/memleak in socket-util

Probably a typo, checking 'ret' instead of the return value 'p'. This
might cause the function to return failure, even though it succeeded.
Furthermore, it might leak resources.
---

diff --git a/src/basic/socket-util.c b/src/basic/socket-util.c
index 62f99b322ec..8fd3149276e 100644
--- a/src/basic/socket-util.c
+++ b/src/basic/socket-util.c
@@ -583,7 +583,7 @@ int sockaddr_pretty(const struct sockaddr *_sa, socklen_t salen, bool translate_
 
                 } else {
                         p = strndup(sa->un.sun_path, sizeof(sa->un.sun_path));
-                        if (!ret)
+                        if (!p)
                                 return -ENOMEM;
                 }