From: Nikos Mavrogiannopoulos <nmav@gnutls.org>
Date: Tue, 10 May 2016 19:55:07 +0000 (+0200)
Subject: _gnutls_krb5_der_to_principal: fixed invalid deinitialization on cleanup
X-Git-Tag: gnutls_3_5_1~192
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=083697ecf6cfc336ddf2fe89b76feea95f369bd2;p=thirdparty%2Fgnutls.git

_gnutls_krb5_der_to_principal: fixed invalid deinitialization on cleanup
---

diff --git a/lib/x509/krb5.c b/lib/x509/krb5.c
index 45b71ba2b9..49096c1e1a 100644
--- a/lib/x509/krb5.c
+++ b/lib/x509/krb5.c
@@ -283,6 +283,8 @@ int _gnutls_krb5_der_to_principal(const gnutls_datum * der, gnutls_datum_t *name
 	ASN1_TYPE c2 = ASN1_TYPE_EMPTY;
 	gnutls_buffer_st str;
 
+	_gnutls_buffer_init(&str);
+
 	result = asn1_create_element(_gnutls_get_gnutls_asn(), "GNUTLS.KRB5PrincipalName", &c2);
 	if (result != ASN1_SUCCESS) {
 		gnutls_assert();
@@ -297,8 +299,6 @@ int _gnutls_krb5_der_to_principal(const gnutls_datum * der, gnutls_datum_t *name
 		goto cleanup;
 	}
 
-	_gnutls_buffer_init(&str);
-
 	ret = principal_to_str(c2, &str);
 	if (ret < 0) {
 		/* for some reason we cannot convert to a human readable string