From: Andrew M. Kuchling <amk@amk.ca>
Date: Tue, 29 Jun 2004 13:19:19 +0000 (+0000)
Subject: [Bug #912845] urllib2 only checks for a 200 return code, but 206 is also legal if... 
X-Git-Tag: v2.4a1~97
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=08c08bb3d1758d6d3bd884ed7c0d6ef8f8524897;p=thirdparty%2FPython%2Fcpython.git

[Bug #912845] urllib2 only checks for a 200 return code, but 206 is also legal if a Range: header was supplied.
(Actually, should the first 'if' statement be modified to allow any 2xx status code?)
---

diff --git a/Lib/urllib2.py b/Lib/urllib2.py
index 301b5dee7830..69f5e040484b 100644
--- a/Lib/urllib2.py
+++ b/Lib/urllib2.py
@@ -468,7 +468,7 @@ class HTTPErrorProcessor(BaseHandler):
     def http_response(self, request, response):
         code, msg, hdrs = response.code, response.msg, response.info()
 
-        if code != 200:
+        if code not in (200, 206):
             response = self.parent.error(
                 'http', request, response, code, msg, hdrs)
 
@@ -996,7 +996,7 @@ class AbstractHTTPHandler(BaseHandler):
         except socket.error, err: # XXX what error?
             raise URLError(err)
 
-        if r.status == 200:
+        if r.status in (200, 206):
             # Pick apart the HTTPResponse object to get the addinfourl
             # object initialized properly
             resp = addinfourl(r.fp, r.msg, req.get_full_url())