From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Sun, 16 Aug 2020 16:27:01 +0000 (-0700)
Subject: [3.8] bpo-41503: Fix race between setTarget and flush in logging.handlers.MemoryHandl... 
X-Git-Tag: v3.8.6rc1~33
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=08f0a2109297e8a64e8636d47dce737e5b7ccf2c;p=thirdparty%2FPython%2Fcpython.git

[3.8] bpo-41503: Fix race between setTarget and flush in logging.handlers.MemoryHandler (GH-21765) (GH-21898)



(cherry picked from commit 2353d77fad7ed9d11d8a4d66b5dd1306cdb94125)


Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>

Automerge-Triggered-By: @vsajip
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 34ff7a056ef5..29802b61d1c1 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -1294,7 +1294,11 @@ class MemoryHandler(BufferingHandler):
         """
         Set the target handler for this handler.
         """
-        self.target = target
+        self.acquire()
+        try:
+            self.target = target
+        finally:
+            self.release()
 
     def flush(self):
         """
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 09b273bf1fb2..cea51b455eed 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -1173,6 +1173,27 @@ class MemoryHandlerTest(BaseTest):
         # assert that no new lines have been added
         self.assert_log_lines(lines)  # no change
 
+    def test_race_between_set_target_and_flush(self):
+        class MockRaceConditionHandler:
+            def __init__(self, mem_hdlr):
+                self.mem_hdlr = mem_hdlr
+
+            def removeTarget(self):
+                self.mem_hdlr.setTarget(None)
+
+            def handle(self, msg):
+                t = threading.Thread(target=self.removeTarget)
+                t.daemon = True
+                t.start()
+
+        target = MockRaceConditionHandler(self.mem_hdlr)
+        self.mem_hdlr.setTarget(target)
+
+        for _ in range(10):
+            time.sleep(0.005)
+            self.mem_logger.info("not flushed")
+            self.mem_logger.warning("flushed")
+
 
 class ExceptionFormatter(logging.Formatter):
     """A special exception formatter."""
diff --git a/Misc/NEWS.d/next/Library/2020-08-07-15-18-16.bpo-41503.IYftcu.rst b/Misc/NEWS.d/next/Library/2020-08-07-15-18-16.bpo-41503.IYftcu.rst
new file mode 100644
index 000000000000..c34996d88193
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2020-08-07-15-18-16.bpo-41503.IYftcu.rst
@@ -0,0 +1 @@
+Fixed a race between setTarget and flush in logging.handlers.MemoryHandler.
\ No newline at end of file