From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Tue, 8 Oct 2024 17:04:34 +0000 (+0100)
Subject: testsuite/test-strbuf: use const char * for strbuf_str()
X-Git-Tag: v34~253
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=097b2c64139852e0f5b92a8d8de9cde44ceb86f3;p=thirdparty%2Fkmod.git

testsuite/test-strbuf: use const char * for strbuf_str()

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/174
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
---

diff --git a/testsuite/test-strbuf.c b/testsuite/test-strbuf.c
index d4644ca0..cc093ec3 100644
--- a/testsuite/test-strbuf.c
+++ b/testsuite/test-strbuf.c
@@ -21,6 +21,7 @@ static const char *TEXT =
 static int test_strbuf_pushchar(const struct test *t)
 {
 	struct strbuf buf;
+	const char *result;
 	char *result1, *result2;
 	const char *c;
 
@@ -29,10 +30,10 @@ static int test_strbuf_pushchar(const struct test *t)
 	for (c = TEXT; *c != '\0'; c++)
 		strbuf_pushchar(&buf, *c);
 
-	result1 = (char *)strbuf_str(&buf);
-	assert_return(result1 == buf.bytes, EXIT_FAILURE);
-	assert_return(streq(result1, TEXT), EXIT_FAILURE);
-	result1 = strdup(result1);
+	result = strbuf_str(&buf);
+	assert_return(result == buf.bytes, EXIT_FAILURE);
+	assert_return(streq(result, TEXT), EXIT_FAILURE);
+	result1 = strdup(result);
 
 	result2 = strbuf_steal(&buf);
 	assert_return(streq(result1, result2), EXIT_FAILURE);
@@ -47,7 +48,8 @@ DEFINE_TEST(test_strbuf_pushchar, .description = "test strbuf_{pushchar, str, st
 static int test_strbuf_pushchars(const struct test *t)
 {
 	struct strbuf buf;
-	char *result1, *saveptr = NULL, *str, *result2;
+	const char *result1;
+	char *saveptr = NULL, *str, *result2;
 	const char *c;
 	size_t lastwordlen = 0;
 
@@ -61,7 +63,7 @@ static int test_strbuf_pushchars(const struct test *t)
 	}
 
 	strbuf_popchar(&buf);
-	result1 = (char *)strbuf_str(&buf);
+	result1 = strbuf_str(&buf);
 	assert_return(result1 == buf.bytes, EXIT_FAILURE);
 	assert_return(streq(result1, TEXT), EXIT_FAILURE);