From: Volker Lendecke <vl@samba.org>
Date: Tue, 3 Sep 2019 08:29:53 +0000 (+0200)
Subject: dsdb: Fix CID 1453465: Null pointer dereferences (NULL_RETURNS)
X-Git-Tag: talloc-2.3.1~992
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=09946c558fade9ea64f0ef2357bf865c6e1ec441;p=thirdparty%2Fsamba.git

dsdb: Fix CID 1453465: Null pointer dereferences (NULL_RETURNS)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c b/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
index 0d46031ec64..7e6d4b160d4 100644
--- a/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
+++ b/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
@@ -834,6 +834,14 @@ static const struct ldb_message *encrypt_secret_attributes(
 			struct ldb_message_element* enc = NULL;
 			if (encrypted_msg == NULL) {
 				encrypted_msg = ldb_msg_copy_shallow(ctx, msg);
+				if (encrypted_msg == NULL) {
+					ldb_set_errstring(
+						ldb,
+						"Out of memory, allocating "
+						"ldb_message_element\n");
+					*err = LDB_ERR_OPERATIONS_ERROR;
+					return NULL;
+				}
 				encrypted_msg->dn = msg->dn;
 			}
 			enc = encrypt_element(err,