From: Raymond Hettinger <python@rcn.com>
Date: Mon, 6 Jan 2003 22:42:41 +0000 (+0000)
Subject: GvR's idea to use memset() for the most common special case of repeating
X-Git-Tag: v2.3c1~2556
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0a2f849b791d13cf0dde97dce2e71a19e2d60465;p=thirdparty%2FPython%2Fcpython.git

GvR's idea to use memset() for the most common special case of repeating
a single character.  Shaves another 10% off the running time by avoiding
the lg2(N) loops and cache effects for the other cases.
---

diff --git a/Objects/stringobject.c b/Objects/stringobject.c
index acfce8b1047a..1a4a7547deb0 100644
--- a/Objects/stringobject.c
+++ b/Objects/stringobject.c
@@ -966,6 +966,11 @@ string_repeat(register PyStringObject *a, register int n)
 	PyObject_INIT_VAR(op, &PyString_Type, size);
 	op->ob_shash = -1;
 	op->ob_sstate = SSTATE_NOT_INTERNED;
+	op->ob_sval[size] = '\0';
+	if (a->ob_size == 1 && n > 0) {
+		memset(op->ob_sval, a->ob_sval[0] , n);
+		return (PyObject *) op;
+	}
 	i = 0;
 	if (i < size) {
 		memcpy(op->ob_sval, a->ob_sval, (int) a->ob_size);
@@ -976,7 +981,6 @@ string_repeat(register PyStringObject *a, register int n)
 		memcpy(op->ob_sval+i, op->ob_sval, j);
 		i += j;
 	}
-	op->ob_sval[size] = '\0';
 	return (PyObject *) op;
 }