From: Joel Rosdahl <joel@rosdahl.net>
Date: Wed, 5 Aug 2020 18:52:25 +0000 (+0200)
Subject: Don’t look up or store tmp stderr files in i-node cache
X-Git-Tag: v4.0~216
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0a991d8161c77313564a703216c3825c2b36cd24;p=thirdparty%2Fccache.git

Don’t look up or store tmp stderr files in i-node cache

The tmp.cpp_stderr file produced by the preprocessor is looked up and
stored in the i-node cache, which is wasted effort since it’s a
temporary file.
---

diff --git a/src/ccache.cpp b/src/ccache.cpp
index f501d8c0e..1b6f99766 100644
--- a/src/ccache.cpp
+++ b/src/ccache.cpp
@@ -1046,8 +1046,7 @@ get_result_name_from_cpp(Context& ctx, Args& args, Hash& hash)
   }
 
   hash.hash_delimiter("cppstderr");
-  if (!ctx.args_info.direct_i_file
-      && !hash_binary_file(ctx, hash, stderr_path)) {
+  if (!ctx.args_info.direct_i_file && !hash.hash_file(stderr_path)) {
     // Somebody removed the temporary file?
     log("Failed to open {}: {}", stderr_path, strerror(errno));
     throw Failure(STATS_ERROR);