From: Andreas Schneider <asn@samba.org>
Date: Thu, 6 Jun 2024 09:51:24 +0000 (+0200)
Subject: selftest: Create the cmd outside of the loop
X-Git-Tag: tdb-1.4.11~357
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0b19bb12a4c6a86cee6fdda1319a173b02934e0a;p=thirdparty%2Fsamba.git

selftest: Create the cmd outside of the loop

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 0ae1eceb7d4..58beee5e8ca 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -3933,14 +3933,14 @@ sub wait_for_start($$$$$)
 	    print "wait for smbd\n";
 
 	    my $count = 0;
-	    do {
-		if (defined($envvars->{GNUTLS_FORCE_FIPS_MODE})) {
+
+	    if (defined($envvars->{GNUTLS_FORCE_FIPS_MODE})) {
 			# We don't have NTLM in FIPS mode, so lets use
 			# smbcontrol instead of smbclient.
 			$cmd = Samba::bindir_path($self, "smbcontrol");
 			$cmd .= " $envvars->{CONFIGURATION}";
 			$cmd .= " smbd ping";
-		} else {
+	    } else {
 			# This uses NTLM which is not available in FIPS
 			$cmd = Samba::bindir_path($self, "smbclient");
 			$cmd .= " $envvars->{CONFIGURATION}";
@@ -3948,8 +3948,9 @@ sub wait_for_start($$$$$)
 			$cmd .= " -U%";
 			$cmd .= " -I $envvars->{SERVER_IP}";
 			$cmd .= " -p 139";
-		}
+	    }
 
+	    do {
 		$ret = system($cmd);
 		if ($ret != 0) {
 		    sleep(1);