From: Thomas Markwalder <tmark@isc.org>
Date: Thu, 19 May 2022 14:56:10 +0000 (-0400)
Subject: [#2354] Addressed review comments
X-Git-Tag: Kea-2.1.6~40
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0b40ccc05f3440546d5f2941845ef4a9bea7e383;p=thirdparty%2Fkea.git

[#2354] Addressed review comments

doc/sphinx/arm/classify.rst
    Added SKIP_DDNS

doc/sphinx/arm/hooks.rst
    Fixed spelling.

src/bin/dhcp6/tests/Makefile.am
    Restored commented out line
---

diff --git a/doc/sphinx/arm/classify.rst b/doc/sphinx/arm/classify.rst
index 0fa0028878..8e6ded67a7 100644
--- a/doc/sphinx/arm/classify.rst
+++ b/doc/sphinx/arm/classify.rst
@@ -166,16 +166,20 @@ be found in :ref:`high-availability-library`.
 The ``BOOTP`` class is used by the BOOTP hook library to classify and
 respond to inbound BOOTP queries.
 
+The ``SKIP_DDNS`` class is used by the DDNS-tuning hook library to suppress
+DDNS updates on a per client basis.
+
 Other examples are the ``ALL`` class, to which all incoming packets belong,
 and the ``KNOWN`` class, assigned when host reservations exist for a
 particular client. By convention, the names of built-in classes begin with all
 capital letters.
 
-Currently recognized built-in class names are ``ALL``, ``KNOWN`` and ``UNKNOWN``, and the
-prefixes ``VENDOR_CLASS_``, ``HA_``, ``AFTER_``, and ``EXTERNAL_``. Although the ``AFTER_``
-prefix is a provision for an as-yet-unwritten hook, the ``EXTERNAL_``
-prefix can be freely used; built-in classes are implicitly defined so
-they never raise warnings if they do not appear in the configuration.
+Currently recognized built-in class names are ``ALL``, ``KNOWN`` and ``UNKNOWN``,
+and the prefixes ``VENDOR_CLASS_``, ``HA_``, ``AFTER_``, ``EXTERNAL_``,
+``SKIP_DDNS``. Although the ``AFTER_`` prefix is a provision for an
+as-yet-unwritten hook, the ``EXTERNAL_`` prefix can be freely used; built-in
+classes are implicitly defined so they never raise warnings if they do not
+appear in the configuration.
 
 .. _classification-using-expressions:
 
diff --git a/doc/sphinx/arm/hooks.rst b/doc/sphinx/arm/hooks.rst
index 0931cfa3b0..2b3a995dc1 100644
--- a/doc/sphinx/arm/hooks.rst
+++ b/doc/sphinx/arm/hooks.rst
@@ -462,7 +462,7 @@ loaded by the correct process per the table below.
    +-----------------+---------------+------------------------------------------------------------+
    | DDNS-Tuning     | ISC support   |This hook library adds support for fine tuning various DDNS |
    |                 | customers     |update aspects such as generating hostnames via expressions |
-   |                 |               |and skipping DDNS updates for select cients.                |
+   |                 |               |and skipping DDNS updates for select clients.               |
    +-----------------+---------------+------------------------------------------------------------+
 
 ISC hopes to see more hook libraries become available as time
diff --git a/src/bin/dhcp6/tests/Makefile.am b/src/bin/dhcp6/tests/Makefile.am
index 6ec1137ae5..e3518f1ad4 100644
--- a/src/bin/dhcp6/tests/Makefile.am
+++ b/src/bin/dhcp6/tests/Makefile.am
@@ -7,7 +7,7 @@ TESTS_ENVIRONMENT = \
         $(LIBTOOL) --mode=execute $(VALGRIND_COMMAND)
 
 # Shell tests
-#SHTESTS = dhcp6_process_tests.sh
+SHTESTS = dhcp6_process_tests.sh
 
 # Run shell tests on "make check".
 check_SCRIPTS = $(SHTESTS)