From: Sam James <sam@gentoo.org>
Date: Sun, 13 Aug 2023 06:46:45 +0000 (+0100)
Subject: basic: add comment for LFS assert in dirent-util.h
X-Git-Tag: v255-rc1~736
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0b4e0943a01496837944b8d7bd1f5cd67597916e;p=thirdparty%2Fsystemd.git

basic: add comment for LFS assert in dirent-util.h

Followup to eb29296937b268e0140a2ab1cf204c2ebb72fa5a as promised; requested
by lennart at https://github.com/systemd/systemd/pull/27599#discussion_r1192619263.
---

diff --git a/src/basic/dirent-util.h b/src/basic/dirent-util.h
index f695885948b..0a2fcbf957a 100644
--- a/src/basic/dirent-util.h
+++ b/src/basic/dirent-util.h
@@ -36,6 +36,8 @@ struct dirent *readdir_no_dot(DIR *dirp);
 /* Only if 64-bit off_t is enabled struct dirent + struct dirent64 are actually the same. We require this, and
  * we want them to be interchangeable to make getdents64() work, hence verify that. */
 assert_cc(_FILE_OFFSET_BITS == 64);
+/* These asserts would fail on musl where the LFS extensions don't exist. They should
+ * always be present on glibc however. */
 #if HAVE_STRUCT_DIRENT64
 assert_cc(sizeof(struct dirent) == sizeof(struct dirent64));
 assert_cc(offsetof(struct dirent, d_ino) == offsetof(struct dirent64, d_ino));