From: Volker Lendecke <vl@samba.org>
Date: Wed, 26 Jun 2019 15:43:44 +0000 (+0200)
Subject: vfs_preopen: TALLOC_FREE(fde) before closing the underlying fd
X-Git-Tag: ldb-2.0.5~148
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0b556e7827b32192cbbce1464e30764648ea1712;p=thirdparty%2Fsamba.git

vfs_preopen: TALLOC_FREE(fde) before closing the underlying fd

Without that we might get wrong stuff out of epoll

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Jun 28 16:42:42 UTC 2019 on sn-devel-184
---

diff --git a/source3/modules/vfs_preopen.c b/source3/modules/vfs_preopen.c
index 6a1ccbd6f04..a2afbf179f8 100644
--- a/source3/modules/vfs_preopen.c
+++ b/source3/modules/vfs_preopen.c
@@ -57,6 +57,7 @@ struct preopen_state {
 static void preopen_helper_destroy(struct preopen_helper *c)
 {
 	int status;
+	TALLOC_FREE(c->fde);
 	close(c->fd);
 	c->fd = -1;
 	kill(c->pid, SIGKILL);