From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 19 Aug 2019 20:21:55 +0000 (-0400)
Subject: Fix a memory-leak warning in test_circuitbuid.c
X-Git-Tag: tor-0.4.2.1-alpha~65^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0bf980705ec3e5a01197615619d62091d1e1f9c8;p=thirdparty%2Ftor.git

Fix a memory-leak warning in test_circuitbuid.c

Coverity wants us to free everything that we are potentially
allocating, even stuff where allocating it would be a bug.  Adding
a smartlist_free() here will fix the warning.

Fixes bug 31452; bugfix on 16a0b7ed6779bf72a8a471c, which is not in
any released Tor.  This is CID 1447292.
---

diff --git a/src/test/test_circuitbuild.c b/src/test/test_circuitbuild.c
index 196d8cd355..7291e04d6a 100644
--- a/src/test/test_circuitbuild.c
+++ b/src/test/test_circuitbuild.c
@@ -167,6 +167,7 @@ test_upgrade_from_guard_wait(void *arg)
   tt_assert(!list);
 
  done:
+  smartlist_free(list);
   circuit_free(circ);
   entry_guard_free_(guard);
 }