From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 28 Nov 2014 04:24:03 +0000 (-0500)
Subject: Fix a memory leak in rend_services_introduce
X-Git-Tag: tor-0.2.6.2-alpha~68
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0bfadbf4b91347eb29c4e7d1a5ccfe2f9c7fd021;p=thirdparty%2Ftor.git

Fix a memory leak in rend_services_introduce

This is CID 1256187 ; bug not in any released tor.
---

diff --git a/src/or/rendservice.c b/src/or/rendservice.c
index ead9f3fe66..26e5659123 100644
--- a/src/or/rendservice.c
+++ b/src/or/rendservice.c
@@ -3073,11 +3073,12 @@ rend_services_introduce(void)
   const or_options_t *options = get_options();
   /* List of nodes we need to _exclude_ when choosing a new node to establish
    * an intro point to. */
-  smartlist_t *exclude_nodes = smartlist_new();
+  smartlist_t *exclude_nodes;
 
   if (!have_completed_a_circuit())
     return;
 
+  exclude_nodes = smartlist_new();
   now = time(NULL);
 
   for (i=0; i < smartlist_len(rend_service_list); ++i) {