From: Alejandro Colomar <alx@kernel.org>
Date: Sat, 3 Jan 2026 13:33:44 +0000 (+0100)
Subject: lib/fields.c: valid_field(): Check empty string before strisprint_c()
X-Git-Tag: 4.20.0-rc1~11
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0c49acaac656ad5ec4628e5f133b89362f0ea5ca;p=thirdparty%2Fshadow.git

lib/fields.c: valid_field(): Check empty string before strisprint_c()

This allows us to not depend on whether strisprint_c("") returns true or
false.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/fields.c b/lib/fields.c
index af9bed077..6f0d77abc 100644
--- a/lib/fields.c
+++ b/lib/fields.c
@@ -45,10 +45,10 @@ valid_field_(const char *field, const char *illegal)
 		return -1;
 	if (strchriscntrl_c(field))
 		return -1;
-	if (strisprint_c(field))
-		return 0;
 	if (streq(field, ""))
 		return 0;
+	if (strisprint_c(field))
+		return 0;
 
 	return 1;  // !ASCII
 }