From: Willy Tarreau <w@1wt.eu>
Date: Fri, 15 May 2026 15:49:16 +0000 (+0200)
Subject: CLEANUP: resolvers: properly initialize the sample in resolv_action_do_resolve()
X-Git-Tag: v3.4-dev13~65
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0c8c9b1c2a968dad0c193edf6a26dcb0022c5813;p=thirdparty%2Fhaproxy.git

CLEANUP: resolvers: properly initialize the sample in resolv_action_do_resolve()

The sample used to pass the IP address only had its data, px, sess and
strm fields initialized before being passed to vars_set_by_name(). It
turns out that this latter one doesn't seem to touch ctx, flags nor opt
but nothing guarantees it. Let's at least initialize the fields properly
to avoid passing random garbage.

No backport is needed.
---

diff --git a/src/resolvers.c b/src/resolvers.c
index f7e6fa04e..463576acb 100644
--- a/src/resolvers.c
+++ b/src/resolvers.c
@@ -3199,7 +3199,7 @@ enum act_return resolv_action_do_resolve(struct act_rule *rule, struct proxy *px
 			if (resolution->status == RSLV_STATUS_NONE)
 				goto yield;
 			if (resolution->status == RSLV_STATUS_VALID) {
-				struct sample smp;
+				struct sample smp = { 0 };
 				short ip_sin_family = 0;
 				void *ip = NULL;