From: Victor Stinner <victor.stinner@gmail.com>
Date: Fri, 22 Jul 2016 15:26:53 +0000 (+0200)
Subject: socket: Fix internal_select()
X-Git-Tag: v3.6.0a4~140^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0cec877230a9232378eb2c7e21348029bbe83fea;p=thirdparty%2FPython%2Fcpython.git

socket: Fix internal_select()

Bug found by Pavel Belikov ("Fragment N1"):
http://www.viva64.com/en/b/0414/#ID0ECDAE
---

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 8f571a2eb4b5..8e804af58c20 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -648,7 +648,7 @@ internal_select(PySocketSockObject *s, int writing, _PyTime_t interval,
     assert(!(connect && !writing));
 
     /* Guard against closed socket */
-    if (s->sock_fd < 0)
+    if (s->sock_fd == INVALID_SOCKET)
         return 0;
 
     /* Prefer poll, if available, since you can poll() any fd