From: Roger Dingledine <arma@torproject.org>
Date: Sun, 11 Nov 2007 04:19:11 +0000 (+0000)
Subject: another likelier candidate for mike's leak
X-Git-Tag: tor-0.2.0.11-alpha~13
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0d219959569df2cfe933555d9fc9cd8397746e48;p=thirdparty%2Ftor.git

another likelier candidate for mike's leak


svn:r12470
---

diff --git a/src/or/dns.c b/src/or/dns.c
index b9775969a7..08a2245367 100644
--- a/src/or/dns.c
+++ b/src/or/dns.c
@@ -312,8 +312,8 @@ dns_free_all(void)
   tor_free(resolv_conf_fname);
 }
 
-/** Remove every cached_resolve whose <b>expire</b> time is before <b>now</b>
- * from the cache. */
+/** Remove every cached_resolve whose <b>expire</b> time is before or
+ * equal to <b>now</b> from the cache. */
 static void
 purge_expired_resolves(time_t now)
 {
@@ -385,6 +385,7 @@ purge_expired_resolves(time_t now)
       /* This should be in state DONE. Make sure it's not in the cache. */
       cached_resolve_t *tmp = HT_FIND(cache_map, &cache_root, resolve);
       tor_assert(tmp != resolve);
+      /* XXX020 shouldn't we be freeing 'resolve' here? */
     }
   }