From: Michał Kępień <michal@isc.org>
Date: Wed, 11 Oct 2017 07:28:44 +0000 (+0200)
Subject: [master] Remove non-portable isc_buffer_printf() unit test
X-Git-Tag: v9.12.0b1~27
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0d61fe5dfda3808cdad2372f6b9985e93b9326d3;p=thirdparty%2Fbind9.git

[master] Remove non-portable isc_buffer_printf() unit test
---

diff --git a/lib/isc/tests/buffer_test.c b/lib/isc/tests/buffer_test.c
index ffb2c5fdb80..054e7fddc0e 100644
--- a/lib/isc/tests/buffer_test.c
+++ b/lib/isc/tests/buffer_test.c
@@ -196,8 +196,8 @@ ATF_TC_HEAD(isc_buffer_printf, tc) {
 }
 
 ATF_TC_BODY(isc_buffer_printf, tc) {
-	const char *bad_fmt, *empty_fmt;
 	unsigned int used, prev_used;
+	const char *empty_fmt;
 	isc_result_t result;
 	isc_buffer_t *b, sb;
 	char buf[8];
@@ -270,16 +270,6 @@ ATF_TC_BODY(isc_buffer_printf, tc) {
 	used = isc_buffer_usedlength(b);
 	ATF_CHECK_EQ(prev_used, used);
 
-	/*
-	 * Ensure vsnprintf() errors do not cause the buffer to be modified.
-	 */
-	prev_used = used;
-	bad_fmt = "%";
-	result = isc_buffer_printf(b, bad_fmt, NULL);
-	ATF_CHECK_EQ(result, ISC_R_FAILURE);
-	used = isc_buffer_usedlength(b);
-	ATF_CHECK_EQ(prev_used, used);
-
 	isc_buffer_free(&b);
 
 	/*