From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 14 Jul 2016 07:34:43 +0000 (+0200)
Subject: krb5pac/netlogon: add a comment regarding PAC_LOGON_INFO unique pointers on push
X-Git-Tag: tdb-1.3.10~291
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0e201ecdc53b07d66342e453b3710d3d06481b8b;p=thirdparty%2Fsamba.git

krb5pac/netlogon: add a comment regarding PAC_LOGON_INFO unique pointers on push

This difference is the reason why we can't fully (ndr)validate some
PAC blobs.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
---

diff --git a/librpc/idl/krb5pac.idl b/librpc/idl/krb5pac.idl
index 33733bf79f7..f27e7243ee4 100644
--- a/librpc/idl/krb5pac.idl
+++ b/librpc/idl/krb5pac.idl
@@ -33,6 +33,12 @@ interface krb5pac
 
 	typedef struct {
 		netr_SamInfo3 info3;
+		/*
+		 * On ndr_push:
+		 * Pointers values of info3.sids[*].sid
+		 * should be allocated before the following ones?
+		 * (just the 0x30 0x00 0x02 0x00 value).
+		 */
 		PAC_DOMAIN_GROUP_MEMBERSHIP resource_groups;
 	} PAC_LOGON_INFO;
 
diff --git a/librpc/idl/netlogon.idl b/librpc/idl/netlogon.idl
index 5eb8e6ae236..621d537a62c 100644
--- a/librpc/idl/netlogon.idl
+++ b/librpc/idl/netlogon.idl
@@ -263,6 +263,14 @@ interface netlogon
 		netr_SamBaseInfo base;
 		uint32 sidcount;
 		[size_is(sidcount)] netr_SidAttr *sids;
+		/*
+		 * On ndr_push:
+		 * Should pointer values be allocated
+		 * of sids[*].sid before the following ones?
+		 *
+		 * That's at least the case for
+		 * PAC_LOGON_INFO.
+		 */
 		lsa_String dns_domainname;
 		lsa_String principal_name;
 		uint32 unknown4[20];