From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 6 Nov 2018 11:34:01 +0000 (+0100)
Subject: ask-password: fix minor memory leak on error path
X-Git-Tag: v240~411
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0e28c86f54f80a6d6364a6024f55eb10b4b5d529;p=thirdparty%2Fsystemd.git

ask-password: fix minor memory leak on error path

CID 1396557
---

diff --git a/src/shared/ask-password-api.c b/src/shared/ask-password-api.c
index df5ede77b95..0240f785c78 100644
--- a/src/shared/ask-password-api.c
+++ b/src/shared/ask-password-api.c
@@ -460,11 +460,9 @@ int ask_password_tty(
                 goto finish;
         }
 
-        l = strv_new(x, NULL);
-        if (!l) {
-                r = -ENOMEM;
+        r = strv_consume(&l, x);
+        if (r < 0)
                 goto finish;
-        }
 
         if (keyname)
                 (void) add_to_keyring_and_log(keyname, flags, l);