From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 26 May 2020 12:47:30 +0000 (+0200)
Subject: sysv: generate warning for every SysV service lacking a native systemd unit
X-Git-Tag: v246-rc1~269^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0e42cbe2541fefaa213eae249ef993a7cfb6367e;p=thirdparty%2Fsystemd.git

sysv: generate warning for every SysV service lacking a native systemd unit

It's 2020, let's tighten the screws a bit and start warning about
left-over SysV services that still have no native systemd unit file.
---

diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c
index a667a8ebad1..3ad139b242b 100644
--- a/src/sysv-generator/sysv-generator.c
+++ b/src/sysv-generator/sysv-generator.c
@@ -788,6 +788,10 @@ static int enumerate_sysv(const LookupPaths *lp, Hashmap *all_services) {
                         if (!fpath)
                                 return log_oom();
 
+                        log_warning("SysV service '%s' lacks a native systemd unit file. "
+                                    "Automatically generating a unit file for compatibility. "
+                                    "Please update package to include a native systemd unit file, in order to make it more safe and robust.", fpath);
+
                         service = new(SysvStub, 1);
                         if (!service)
                                 return log_oom();