From: Karel Zak <kzak@redhat.com>
Date: Wed, 2 Oct 2013 12:43:17 +0000 (+0200)
Subject: su: fix caught_signal logic and initialize oldact [coverity scan]
X-Git-Tag: v2.24-rc2~65
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0e8edc9f9ef398e0b0d3104a44c75722b66e8f96;p=thirdparty%2Futil-linux.git

su: fix caught_signal logic and initialize oldact [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index 858af0176f..7f1b505bfc 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -288,6 +288,8 @@ create_watching_parent (void)
   else
     _pam_session_opened = 1;
 
+  memset(oldact, 0, sizeof(oldact));
+
   child = fork ();
   if (child == (pid_t) -1)
     {
@@ -408,6 +410,9 @@ create_watching_parent (void)
           sigaction(SIGQUIT, &oldact[2], NULL);
           break;
         default:
+	  /* just in case that signal stuff initialization failed and
+	   * caught_signal = true */
+          caught_signal = SIGKILL;
           break;
       }
       kill(0, caught_signal);