From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Mon, 6 Jan 2020 09:44:19 +0000 (+0100)
Subject: pkcs11-util: don't mask return value of the first asprintf()
X-Git-Tag: v245-rc1~189
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0e97a910a63d338f0acce6302de76b3e96c9cd70;p=thirdparty%2Fsystemd.git

pkcs11-util: don't mask return value of the first asprintf()

Fixes CID#1409666
---

diff --git a/src/shared/pkcs11-util.c b/src/shared/pkcs11-util.c
index fac98ad0ead..3fcd7630db6 100644
--- a/src/shared/pkcs11-util.c
+++ b/src/shared/pkcs11-util.c
@@ -218,7 +218,7 @@ int pkcs11_token_login(
                         r = asprintf(&text,
                                      "Please enter correct PIN for security token '%s' in order to unlock %s (final try):",
                                      token_label, friendly_name);
-                if (FLAGS_SET(token_info->flags, CKF_USER_PIN_COUNT_LOW))
+                else if (FLAGS_SET(token_info->flags, CKF_USER_PIN_COUNT_LOW))
                         r = asprintf(&text,
                                      "PIN has been entered incorrectly previously, please enter correct PIN for security token '%s' in order to unlock %s:",
                                      token_label, friendly_name);