From: Rob van der Linde <rob@catalyst.net.nz>
Date: Mon, 30 Oct 2023 23:27:56 +0000 (+1300)
Subject: netcmd: silo member add and remove should not set assigned_silo
X-Git-Tag: talloc-2.4.2~756
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0eb727a54d421ac634bee92b6ebaad304fcfe426;p=thirdparty%2Fsamba.git

netcmd: silo member add and remove should not set assigned_silo

The Windows tools don't do this either

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/netcmd/domain/auth/silo_member.py b/python/samba/netcmd/domain/auth/silo_member.py
index 638ad59b8ca..4094ba76840 100644
--- a/python/samba/netcmd/domain/auth/silo_member.py
+++ b/python/samba/netcmd/domain/auth/silo_member.py
@@ -69,13 +69,9 @@ class cmd_domain_auth_silo_member_add(Command):
         if user is None:
             raise CommandError(f"User '{member}' not found.")
 
-        # Set the assigned silo.
-        user.assigned_silo = silo.dn
-
-        # Add member and save user.
+        # Add member.
         try:
             silo.add_member(ldb, user)
-            user.save(ldb)
         except ModelError as e:
             raise CommandError(e)
 
@@ -172,13 +168,9 @@ class cmd_domain_auth_silo_member_remove(Command):
         if user is None:
             raise CommandError(f"User '{member}' not found.")
 
-        # Unset the assigned silo.
-        user.assigned_silo = None
-
-        # Remove member and save user.
+        # Remove member.
         try:
             silo.remove_member(ldb, user)
-            user.save(ldb)
         except ModelError as e:
             raise CommandError(e)