From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 25 May 2016 12:59:08 +0000 (-0400)
Subject: Use calloc, not malloc(a*b), in ed25519 batch signature check fn
X-Git-Tag: tor-0.2.9.1-alpha~214
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0ef36626ea0b3735d06360fde27100d33f2f5462;p=thirdparty%2Ftor.git

Use calloc, not malloc(a*b), in ed25519 batch signature check fn

[Not a triggerable bug unless somebody is going to go checking
millions+ of signatures in a single go.]
---

diff --git a/src/common/crypto_ed25519.c b/src/common/crypto_ed25519.c
index c687a1b246..84c3eece6d 100644
--- a/src/common/crypto_ed25519.c
+++ b/src/common/crypto_ed25519.c
@@ -259,11 +259,11 @@ ed25519_checksig_batch(int *okay_out,
     int *oks;
     int all_ok;
 
-    ms = tor_malloc(sizeof(uint8_t*)*n_checkable);
-    lens = tor_malloc(sizeof(size_t)*n_checkable);
-    pks = tor_malloc(sizeof(uint8_t*)*n_checkable);
-    sigs = tor_malloc(sizeof(uint8_t*)*n_checkable);
-    oks = okay_out ? okay_out : tor_malloc(sizeof(int)*n_checkable);
+    ms = tor_calloc(n_checkable, sizeof(uint8_t*));
+    lens = tor_calloc(n_checkable, sizeof(size_t));
+    pks = tor_calloc(n_checkable, sizeof(uint8_t*));
+    sigs = tor_calloc(n_checkable, sizeof(uint8_t*));
+    oks = okay_out ? okay_out : tor_calloc(n_checkable, sizeof(int));
 
     for (i = 0; i < n_checkable; ++i) {
       ms[i] = checkable[i].msg;