From: Amos Jeffries <squid3@treenet.co.nz>
Date: Fri, 10 Apr 2009 05:21:33 +0000 (+1200)
Subject: Bug 2518: assertion failed: comm.cc:1519: "F->flags.open"
X-Git-Tag: SQUID_3_1_0_8~56
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0f2d8996e65b8b26dfdfed299bf87211c65a0d08;p=thirdparty%2Fsquid.git

Bug 2518: assertion failed: comm.cc:1519: "F->flags.open"

Not seen in a while. I suspect its hiding behind a fixed F->closing()
test, so the whole if test may be obsolete.

Applying in order to close the bug with surety and sync the conditions on
shutdown and restart-closing.
---

diff --git a/src/comm.cc b/src/comm.cc
index 4e5caef1cc..d0529ba5d0 100644
--- a/src/comm.cc
+++ b/src/comm.cc
@@ -1548,7 +1548,8 @@ _comm_close(int fd, char const *file, int line)
     if (F->closing())
         return;
 
-    if (shutting_down && (!F->flags.open || F->type == FD_FILE))
+    /* XXX: is this obsolete behind F->closing() ? */
+    if ( (shutting_down || reconfiguring) && (!F->flags.open || F->type == FD_FILE))
         return;
 
     /* The following fails because ipc.c is doing calls to pipe() to create sockets! */