From: Naoki Kambe Date: Tue, 25 Sep 2012 09:25:51 +0000 (+0900) Subject: [2222] removed axfr_running checking after starting transferring X-Git-Tag: trac2351_base~44^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0f3f6b1f3cdc54176c1abf4b22bbdfe4dbae0a5c;p=thirdparty%2Fkea.git [2222] removed axfr_running checking after starting transferring As result of the review on #2222, we agreed that that test doesn't make sense. We can observe increased axfr_running only in a situation that transferring takes longer than one second. In this lettuce situation, transferring would be done in shorter than one second. So that test was removed. --- diff --git a/tests/lettuce/features/xfrin_notify_handling.feature b/tests/lettuce/features/xfrin_notify_handling.feature index ffde7b9d34..80a8873301 100644 --- a/tests/lettuce/features/xfrin_notify_handling.feature +++ b/tests/lettuce/features/xfrin_notify_handling.feature @@ -45,14 +45,6 @@ Feature: Xfrin incoming notify handling Then wait for new bind10 stderr message AUTH_RECEIVED_NOTIFY Then wait for new bind10 stderr message ZONEMGR_RECEIVE_NOTIFY Then wait for new bind10 stderr message XFRIN_XFR_TRANSFER_STARTED - And when I query statistics axfr_running of bind10 module Xfrout with cmdctl port 47804 - - # The counter may or may not have been incremented. Whatever the - # server likes. This test should have been actually effective but - # the axfr transfering is mostly done in real short time. it is - # hardly to observe 'axfr_running' incremented to one. - Then the statistics counter axfr_running should be between 0 and 1 - Then wait for new bind10 stderr message XFRIN_TRANSFER_SUCCESS not XFRIN_XFR_PROCESS_FAILURE Then wait for new bind10 stderr message ZONEMGR_RECEIVE_XFRIN_SUCCESS Then wait 5 times for new master stderr message NOTIFY_OUT_SENDING_NOTIFY