From: Pavel Filipenský <pfilipen@redhat.com>
Date: Fri, 24 Jun 2022 11:01:23 +0000 (+0200)
Subject: s3:winbind: Improve logging in winbindd_wins_byname.c
X-Git-Tag: tevent-0.13.0~129
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0f4c7404d65746f924086aafc0f16bd9a718a500;p=thirdparty%2Fsamba.git

s3:winbind: Improve logging in winbindd_wins_byname.c

Test scenario:
$  bin/wbinfo --WINS-by-name=ADDC

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/winbindd/winbindd_wins_byname.c b/source3/winbindd/winbindd_wins_byname.c
index 0758dcb761f..f640cc2dc52 100644
--- a/source3/winbindd/winbindd_wins_byname.c
+++ b/source3/winbindd/winbindd_wins_byname.c
@@ -53,8 +53,11 @@ struct tevent_req *winbindd_wins_byname_send(TALLOC_CTX *mem_ctx,
 	/* Ensure null termination */
 	request->data.winsreq[sizeof(request->data.winsreq)-1]='\0';
 
-	DEBUG(3, ("[%5lu]: wins_byname %s\n", (unsigned long)cli->pid,
-		  request->data.winsreq));
+	D_NOTICE("[%s (%u)] Winbind external command WINS_BYNAME start.\n"
+		 "Resolving wins byname for '%s'.\n",
+		 cli->client_name,
+		 (unsigned int)cli->pid,
+		 request->data.winsreq);
 
 	subreq = resolve_wins_send(state, ev, state->request->data.winsreq,
 				   0x20);
@@ -123,10 +126,13 @@ NTSTATUS winbindd_wins_byname_recv(struct tevent_req *req,
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	D_NOTICE("Winbind external command WINS_BYNAME end.\n"
+		 "Received %lu address(es).\n",
+		 state->num_addrs);
 	for (i=0; i<state->num_addrs; i++) {
 		char addr[INET6_ADDRSTRLEN];
 		print_sockaddr(addr, sizeof(addr), &state->addrs[i]);
-
+		D_NOTICE("%lu: %s\n", i, addr);
 		response = talloc_asprintf_append_buffer(
 			response, "%s%s", addr,
 			i < (state->num_addrs-1) ? " " : "");